gpg: Fix _ostree_gpg_verifier_add_keyring()

The function never fails, but its API makes it look like it can.

Fortunately it's private, so just fix it.

diff --git a/src/libostree/ostree-gpg-verifier.c b/src/libostree/ostree-gpg-verifier.c
index 96ca7c65dd4c0b9e7f8c54ac6892d48c9de133ab..42581b3fd5bec27d8bcfedfb7b88ef9af34255db 100644 (file)
--- a/src/libostree/ostree-gpg-verifier.c
+++ b/src/libostree/ostree-gpg-verifier.c
@@ -259,16 +259,13 @@ out:
   return result;
 }
 
-gboolean
+void
 _ostree_gpg_verifier_add_keyring (OstreeGpgVerifier  *self,
-                                  GFile              *path,
-                                  GCancellable       *cancellable,
-                                  GError            **error)
+                                  GFile              *path)
 {
-  g_return_val_if_fail (path != NULL, FALSE);
+  g_return_if_fail (G_IS_FILE (path));
 
   self->keyrings = g_list_append (self->keyrings, g_object_ref (path));
-  return TRUE;
 }
 
 gboolean

diff --git a/src/libostree/ostree-gpg-verifier.h b/src/libostree/ostree-gpg-verifier.h
index b505d85a56e43c9cf29c18d521885c1190f2c5c7..54be424fbb8f75b50c80bb9da96ad3692fcd6aef 100644 (file)
--- a/src/libostree/ostree-gpg-verifier.h
+++ b/src/libostree/ostree-gpg-verifier.h
@@ -51,8 +51,7 @@ gboolean      _ostree_gpg_verifier_add_keyring_dir (OstreeGpgVerifier   *self,
                                                     GCancellable        *cancellable,
                                                     GError             **error);
 
-gboolean      _ostree_gpg_verifier_add_keyring (OstreeGpgVerifier   *self,
-                                                GFile               *path,
-                                                GCancellable        *cancellable,
-                                                GError             **error);
+void _ostree_gpg_verifier_add_keyring (OstreeGpgVerifier *self,
+                                       GFile             *path);
+
 G_END_DECLS

diff --git a/src/libostree/ostree-repo.c b/src/libostree/ostree-repo.c
index 5bdba3c659e20faff242ab51a0df4be4a2db362e..1ec18af43160c73a24ddacae78efa9cb6b21443b 100644 (file)
--- a/src/libostree/ostree-repo.c
+++ b/src/libostree/ostree-repo.c
@@ -3376,9 +3376,7 @@ _ostree_repo_gpg_verify_with_metadata (OstreeRepo          *self,
     }
   if (extra_keyring != NULL)
     {
-      if (!_ostree_gpg_verifier_add_keyring (verifier, extra_keyring,
-                                             cancellable, error))
-        goto out;
+      _ostree_gpg_verifier_add_keyring (verifier, extra_keyring);
     }
 
   if (metadata)